Repository navigation
chore: add showcase integration tests for OpenTelemetry span scope in logging and metrics - #15041
jinseopkim0 wants to merge 1 commit into
Conversation
… logging and metrics
There was a problem hiding this comment.
Code Review
This pull request introduces integration tests to verify that OpenTelemetry span contexts are correctly captured and correlated during error logging for both HTTP/JSON and gRPC transports. Specifically, it adds testHttpJson_spanContextCapturedInScopeDuringErrorLog and testGrpc_spanContextCapturedInScopeDuringErrorLogAndDownstreamInterceptor to ITActionableErrorsLogging.java, along with helper methods to build a nested composite tracer factory and assert span correlation. Additionally, TestAppender.java is updated to capture and store the active OpenTelemetry SpanContext when log events are appended. I have no feedback to provide as the changes are well-implemented and there are no existing review comments to address.
Adds Showcase integration tests verifying that diagnostic error logs (L4/L3), golden signal metric exemplars (M1), and downstream gRPC client interceptors observe the active OpenTelemetry span across HTTP/JSON and gRPC calls, including nested
CompositeTracerFactoryconfigurations.(Stacked on #15033 and #15034; base branch will be retargeted to
mainonce those merge.)b/499388983
b/570676007